From 0f5874ea7c5b25152f448d8c46efee50b1c023ad Mon Sep 17 00:00:00 2001 From: Joel Klinghed Date: Thu, 25 Apr 2024 00:25:05 +0200 Subject: args: Borrow string when printing it Seems like a better default, unsure if it made any difference here tho. --- src/args.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/args.rs b/src/args.rs index 5081a15..919b41a 100644 --- a/src/args.rs +++ b/src/args.rs @@ -108,7 +108,7 @@ pub trait Parser { }); } - fn print_help_fn(&self, options: &Options, println: &dyn Fn(String)); + fn print_help_fn(&self, options: &Options, println: &dyn Fn(&String)); } #[allow(dead_code)] @@ -117,19 +117,19 @@ pub struct LongOnlyParser {} #[allow(dead_code)] pub struct ShortAndLongParser {} -fn print_list(list: Vec<(String, &str)>, println: &dyn Fn(String)) { +fn print_list(list: Vec<(String, &str)>, println: &dyn Fn(&String)) { let mut left_len: usize = 0; for (left, _) in &list { left_len = std::cmp::max(left_len, left.len()); } for (left, right) in &list { let mut right_lines = right.split('\n'); - println(format!( + println(&format!( "{left: